Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JSON request bodies are decoded into
map[string]interface{}numeric fields becomefloat64. Theenum/invalidation only handledstring,intanduinttypes, causing valid JSON numbers to fail validation unless callers explicitly converted them with Filters. This change keeps the existingconvToBasicTypeattempt and, if that fails, falls back to converting the value to a string and re-using the same enum matching logic. It's a small, backward-compatible fix that letsin:rules work with numbers coming from JSON without requiring extra Filters.This update addresses goravel/goravel#816