Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C256ToRgb(16)returns[0, 0, 1]instead of black, and palette entry 244 returns[128, 128, 129]instead of gray. Several RGB keys are deliberately nudged inhexTo256Tableto represent duplicate palette colors, so reversing that lookup also reverses those artificial values.Decode the 6×6×6 color cube and grayscale ramp from their palette indices. Keep the existing mapping for the first 16 colors. The regression test checks every cube/ramp entry against its RGB values.
Validation: the palette test fails before the fix; the full race/coverage suite passes (98.8% main package coverage) with
NO_COLOR='' COLORTERM=truecolor TERM=xterm-256color. Vet passes. Staticcheck reports existing unused declarations and a redundant fmt.Sprint outside the changed code.