Added SystemVerilog syntax highlighting#433
Added SystemVerilog syntax highlighting#433BooneJS wants to merge 1 commit intogooglearchive:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I added an alternate email address that the commit came from. |
|
CLAs look good, thanks! |
|
BTW, this fixes Feature Request Issue #310. |
|
Any update on the status of this pull request? The stack exchange network uses Prettify for it's syntax highlighting. There are a few of us wanting Verilog/SystemVerilog (SV) syntax highlighting support (Q on the StackExchange Meta), but that is entirely dependent on Prettify getting SV support. |
|
@BooneJS I'm asking this question, because I don't know the procedure here. Will this commit be merged? Since Stack Overflow uses code-prettify, your extension would be great for many people. |
|
As far as I know, I’ve signed the Google CLA and it’s all ready for them to accept the pull request. |
|
This PR was issued over 3 years ago. Can it be merged? |
|
There's 44 PRs and very little activity across this library. This may never be merged. |
I've created lang-sv.js based off of lang-vhdl.js, and modified as appropriate. Please consider taking this PR, as I use Perforce Swarm and it uses code-prettify as its syntax highlighter.
It also appears my editor's desire to trim all trailing whitespace caused other differences. I hope that's ok.
Thank you,
BooneJS