Skip to content

feat(sql): add Backups and FeatureEligibility services - #16302

Open
scotthart wants to merge 4 commits into
googleapis:mainfrom
scotthart:sqladmin_add_backups_features
Open

feat(sql): add Backups and FeatureEligibility services#16302
scotthart wants to merge 4 commits into
googleapis:mainfrom
scotthart:sqladmin_add_backups_features

Conversation

@scotthart

@scotthart scotthart commented Jul 31, 2026

Copy link
Copy Markdown
Member

PiperOrigin-RevId: 952134922

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the Cloud SQL Admin API library to include the Backups and FeatureEligibility services, which are configured to use REST transport only. The review feedback correctly points out that the documentation in environment-variables.dox incorrectly references the non-existent gRPC connection factories MakeSqlBackupsServiceConnection() and MakeSqlFeatureEligibilityServiceConnection(), and should be updated to refer to their REST counterparts (MakeSqlBackupsServiceConnectionRest() and MakeSqlFeatureEligibilityServiceConnectionRest()).

Comment thread google/cloud/sql/doc/environment-variables.dox
Comment thread google/cloud/sql/doc/environment-variables.dox
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (842dfb2) to head (53ed804).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16302      +/-   ##
==========================================
- Coverage   92.30%   92.30%   -0.01%     
==========================================
  Files        2223     2223              
  Lines      208177   208177              
==========================================
- Hits       192165   192158       -7     
- Misses      16012    16019       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants