Skip to content

ci: harden Dependencies job against go-mod-outdated proxy flakes - #354

Merged
lkmavi merged 1 commit into
mainfrom
fix/ci-deps-go-mod-outdated-flake
Sep 7, 2026
Merged

lkmavi merged 1 commit into
mainfrom
fix/ci-deps-go-mod-outdated-flake

Conversation

@lkmavi

@lkmavi lkmavi commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The advisory Dependencies job was failing PRs when go install github.com/psampaz/go-mod-outdated@latest hit a transient proxy.golang.org INTERNAL_ERROR (e.g. #353 run).
  • Pin go-mod-outdated@v0.9.0, retry install up to 3 times, and continue-on-error so a module-proxy blip cannot red the check; skip the direct-deps step if install still fails. Ecosystem checks still run.

Test plan

  • CI on this PR: Dependencies job succeeds (or soft-continues) even if a single install attempt flakes
  • Confirm direct-deps step runs when install succeeds; ecosystem step always runs
  • Re-check that a green PR is no longer blocked solely by this advisory job

Install was failing the advisory deps check when proxy.golang.org returned
INTERNAL_ERROR on the zip download. Pin v0.9.0, retry, and continue so a
transient module-proxy blip cannot red an otherwise-green PR.
@lkmavi
lkmavi requested a review from kolkov as a code owner September 7, 2026 18:19
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kolkov kolkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI hardening — pin version, retry with backoff, continue-on-error for advisory check. Standard practice, prevents proxy.golang.org flakes from blocking PRs. LGTM.

@lkmavi
lkmavi merged commit 2aba097 into main Sep 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants