fix(traces/gcp): bring the gofr.dev v1.62.0 pin to main - #4409
Merged
aryanmehrotra merged 1 commit intoOct 1, 2026
Merged
Conversation
The exporter plugs into pkg/gofr/traces/exporters, which first shipped in gofr.dev v1.62.0. Its go.mod still required v1.60.1 behind a replace to the repo root. Consumers ignore a dependency's replace, so a consumer on gofr.dev v1.61.0 or older resolved a gofr without that package and the go command had to upgrade gofr on its own to build; under -mod=readonly the build fails. Require v1.62.0 directly, the same step the metrics exporter took in #3926 once a release carried the core it needs. Closes the TODO for #4210.
Umang01-hash
approved these changes
Oct 1, 2026
aryanmehrotra
deleted the
fix/traces-gcp-exporter-require-v1.62.0-to-main
branch
October 1, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
traces/exporters/gcpis the keyless Google Cloud trace exporter that the v1.62.0 release notes advertise, and it is the only submodule that could not be tagged with the rest of v1.62.0. Itsgo.modrequiredgofr.dev v1.60.1behindreplace gofr.dev => ../../../../...replaceis ignored by the consuming module. The package it plugs into,pkg/gofr/traces/exporters, first shipped ingofr.dev v1.62.0. So the exporter declared a requirement it cannot build against.replaceand its TODO (gcp traces submodule: drop thereplace gofr.devonce a release contains pkg/gofr/traces/exporters #4210), and requiregofr.dev v1.62.0.go mod tidyadds 2go.sumlines. This is the same step the metrics exporter took in fix(metrics): require gofr.dev v1.59.0 in the gcp exporter so it builds for consumers #3926 / fix(metrics): bring the gcp exporter go.mod fix to main #3928.Verification (
GOWORK=off, so the repo-rootgo.workcannot hide a wrong pin):go build/go vetgo test -count=1 ./...golangci-lintv2.12.2gofr.dev v1.61.0, old go.modfound gofr.dev/pkg/gofr/traces/exporters in gofr.dev v1.62.0(an implicit upgrade; fails under-mod=readonly)Breaking Changes (if applicable):
None. The module has never been tagged.
Additional Information:
There are two PRs with the same commit, following #4147 / #4148: #4408 into
developmentand #4409 intomain. After themainone merges, tagpkg/gofr/traces/exporters/gcp/v0.1.0on that merge commit. The other 27 submodule tags for v1.62.0 are already pushed.