Improve clarity in networking documentation - #12408
Merged
Merged
Conversation
Clarify the connection details for clients outside the LAN and update signal descriptions for peer connections and disconnections.
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Contributor
Author
|
Apologies for my bad rst syntax and thank you AThousandShips for your review |
Calinou
reviewed
Sep 25, 2026
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
AThousandShips
approved these changes
Sep 28, 2026
skyace65
approved these changes
Sep 30, 2026
Member
|
Thanks! And congrats on your first merged PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify wording for clients outside the LAN and for signal descriptions for peer connections and disconnections.