fix: correct reply_to_story field name and json tag on Message#287
Open
Kazemir wants to merge 1 commit into
Open
fix: correct reply_to_story field name and json tag on Message#287Kazemir wants to merge 1 commit into
Kazemir wants to merge 1 commit into
Conversation
The field for the Bot API `reply_to_story` was declared as `ReplyToStore` with a `json:"reply_to_store"` tag (typo: "store" instead of "story"), so Telegram's `reply_to_story` was never unmarshalled into the struct. Rename the field to `ReplyToStory` and fix the tag to `reply_to_story`. Add an unmarshal test covering the field. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Message.ReplyToStoreis declared with ajson:"reply_to_store"tag — a typo of the Bot API field, which isreply_to_story(aStorysent in reply to a story). Because the tag doesn't match, Telegram'sreply_to_storyis never unmarshalled and the field is alwaysnil.Fix
ReplyToStore→ReplyToStoryand fix the tag toreply_to_story.The field isn't referenced anywhere else in the library, and it never populated before, so nothing depended on the old (typo) name.
Verification
gofmtclean,go vet ./models/clean.go test ./models/passes, including the newTestUnmarshalMessage_replyToStory.