Skip to content

fix: use button to replace anchor elements without href - #40338

Open
lazerg wants to merge 11 commits into
go-gitea:mainfrom
lazerg:fix/issue-40337-release-delete-button
Open

lazerg wants to merge 11 commits into
go-gitea:mainfrom
lazerg:fix/issue-40337-release-delete-button

Conversation

@lazerg

@lazerg lazerg commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Elements <a> without href are not focus-able, screen readers didn't expose it as a button.

Use <button type="button"> for these elements.

Fixes: #40337

Assisted-by: Claude Code:claude-opus-5-5
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2026
@wxiaoguang wxiaoguang changed the title fix(release): use a button for the delete release action fix: use button to replace a elements without href Nov 12, 2026
@wxiaoguang
wxiaoguang force-pushed the fix/issue-40337-release-delete-button branch from 75728c9 to 3397543 Compare November 12, 2026 10:43
@wxiaoguang wxiaoguang changed the title fix: use button to replace a elements without href fix: use button to replace anchor elements without href Nov 12, 2026
@wxiaoguang
wxiaoguang force-pushed the fix/issue-40337-release-delete-button branch from 3397543 to 18c50da Compare November 12, 2026 10:46
@wxiaoguang
wxiaoguang force-pushed the fix/issue-40337-release-delete-button branch from 18c50da to 4b0a843 Compare November 12, 2026 10:56

This comment was marked as resolved.

wxiaoguang and others added 2 commits November 12, 2026 19:38
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
wxiaoguang force-pushed the fix/issue-40337-release-delete-button branch from 44a2844 to 5682083 Compare November 12, 2026 11:54
@wxiaoguang
wxiaoguang requested a lite review from Copilot November 12, 2026 11:56

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

An active moderate accessibility issue remains because the 16 keyboard-focusable color swatch buttons lack accessible names, preventing assistive technologies from identifying their selections.

No open issues 🎉

Review effort: Lite

@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2026
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/bug

Projects

None yet

4 participants