Feat/audit vague2 vm fixes#7
Merged
Merged
Conversation
Covers six GnoVM fixes from the last quarter not yet tested on-chain: - audit_cross_realm_p_arithmetic.sh — 9e56b0c77 (/p/-type arithmetic cross-realm) - audit_preprocess_alloc_caps.sh — c98a2cdca (per-tx allocator cap) - audit_panic_log_dos.sh — 4bb497abe (bounded panic-Log rendering) - audit_map_key_gas.sh — 720af8bcd (gas on ComputeMapKey) - audit_nil_func_call.sh — a7e4c34b0 (nil func call → Gno panic) - audit_type_assert_nil.sh — 6dad8e39d (nil interface type assertion → Gno panic) All scripts use maketx run (no cur realm parameter needed — PR #5669). Node-crash tests (nil_func_call, type_assert_nil) include a liveness check after the rejected tx to confirm the node is still responsive.
… not runtime alloc The fix (c98a2cdca) targets the preprocessor (MsgAddPackage type-checking phase), not runtime allocation. make([]byte, 100M) tests the wrong code path. New approach: deploy a 10-level struct embed chain (> cap of 8) — preprocessor must reject it. 6-level embed (< cap) must still deploy successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wave 2 audit tests — VM fix regressions (6 scripts)
Covers six GnoVM fixes from the last quarter not yet tested on-chain.
Scripts
audit_cross_realm_p_arithmetic9e56b0c77/p/-type arithmetic across realm boundariesaudit_preprocess_alloc_capsc98a2cdcaaudit_panic_log_dos4bb497abeaudit_map_key_gas720af8bcdComputeMapKey(10k complex keys OOGs)audit_nil_func_calla7e4c34b0audit_type_assert_nil6dad8e39dNotes
audit_preprocess_alloc_capstests the preprocessor (type-checking phaseduring
MsgAddPackage), not runtime allocation — the fix bounds embed-chaindepth at 8. An initial version tested
make([]byte, 100M)which was the wrongcode path.
All scripts use
maketx run(functions have nocur realm— PR #5669).Test results
All six pass as PATCHED on test-13.