-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Accessibility best practices #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
158ba36
79981fb
8be6cd5
3f9bc3f
5f80edc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,265 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| lang: en | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| untranslated: true | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| title: Accessibility Best Practices for Your Project | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| description: Practical, actionable steps to make your open source project usable by everyone, especially people with disabilities. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| class: accessibility-best-practices | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| order: -1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| image: /assets/images/cards/accessibility-best-practices.png | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| image: /assets/images/cards/accessibility-best-practices.png | |
| image: /assets/images/cards/default.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlama007 was there an internal asset created for this that you'd want to use?
Copilot
AI
Apr 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide introduces #### (H4) headings (e.g., “Goals”, “Contributor requirements”, etc.). A repo-wide search shows no other _articles/*.md files use H4 headings, which suggests the site’s content conventions (and possibly styling/TOC behavior) expect only ##/###. Consider converting these to ### sections or keeping them as bold lead-ins within a list instead of deeper heading levels.
| #### **Goals** | |
| - State measurable goals (like WCAG AA where feasible), primary priorities (keyboard, screen reader, captions), and any known limitations. | |
| #### **Contributor requirements** | |
| - Establish clear guardrails so contributors know what's expected: | |
| - **Testing:** All UI changes must be tested with an accessibility testing tool (like Axe DevTools). | |
| - **Documentation:** Follow your project's accessibility guidelines for components like SVGs, images, and interactive elements. | |
| - **CI/CD:** PRs will fail if they introduce violations detected by the accessibility linting workflow. | |
| #### **Supported environments** | |
| - List platforms you support (web, mobile web, iOS, Android, terminal/CLI, desktop apps) and any partial-support notes. | |
| #### **Reporting accessibility bugs** | |
| ### Goals | |
| - State measurable goals (like WCAG AA where feasible), primary priorities (keyboard, screen reader, captions), and any known limitations. | |
| ### Contributor requirements | |
| - Establish clear guardrails so contributors know what's expected: | |
| - **Testing:** All UI changes must be tested with an accessibility testing tool (like Axe DevTools). | |
| - **Documentation:** Follow your project's accessibility guidelines for components like SVGs, images, and interactive elements. | |
| - **CI/CD:** PRs will fail if they introduce violations detected by the accessibility linting workflow. | |
| ### Supported environments | |
| - List platforms you support (web, mobile web, iOS, Android, terminal/CLI, desktop apps) and any partial-support notes. | |
| ### Reporting accessibility bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this; you could change the line "A clear statement sets expectations and makes it easy for users to report issues." to not be a header and then move all of the #### up a level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ##### Why separate accessibility from your general issue process? | |
| ### Why separate accessibility from your general issue process? |
this could also go up to a h3 instead of h5.
Copilot
AI
Apr 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar issue: this sentence is a comma splice (two independent clauses joined by a comma). Consider splitting into two sentences or using an em dash/semicolon.
| Documentation is often the first "UI" users touch, make sure everyone can read it. | |
| Documentation is often the first "UI" users touch. Make sure everyone can read it. |
Copilot
AI
Apr 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s an extra space before the comma in the inline heading-level list, which reads as a typo.
| - Use a **logical heading hierarchy** and don't skip levels (`#` , `##`, `###`, `####`, `#####`, and `######`). | |
| - Use a **logical heading hierarchy** and don't skip levels (`#`, `##`, `###`, `####`, `#####`, and `######`). |
Copilot
AI
Apr 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Contributors list ends with a placeholder TBD. Please remove the placeholder or replace it with actual contributor attribution before publishing so the guide doesn’t ship with unfinished content.
| This guide was written by [@mlama007](https://github.com/mlama007) with contributions from: [@ericwbailey](https://github.com/ericwbailey), [@andyfeller](https://github.com/andyfeller), [@mgifford](https://github.com/mgifford), TBD | |
| This guide was written by [@mlama007](https://github.com/mlama007) with contributions from: [@ericwbailey](https://github.com/ericwbailey), [@andyfeller](https://github.com/andyfeller), [@mgifford](https://github.com/mgifford) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR template checkboxes in the PR description are still unchecked. Please check them and add the requested explanation so the PR isn’t closed by automation.