Skip to content

Rust: Simplify extractor command-line option parsing - #23054

Draft
paldepind wants to merge 2 commits into
mainfrom
rust/extractor-cli-args
Draft

paldepind wants to merge 2 commits into
mainfrom
rust/extractor-cli-args

Conversation

@paldepind

Copy link
Copy Markdown
Contributor

Summary

  • Replace macro-generated CLI options with explicit support for --file-list, --qltest, and --logging-verbosity, the flags used by the extractor pack.
  • Preserve the full configuration through environment variables and options.yml, including defaults, custom deserialization, and override precedence.
  • Remove the macro crate and serde_with, and regenerate Cargo/Bazel metadata to prune unused dependencies without upgrading packages.
  • Add focused regression tests for removed flags and preserved configuration behavior.

Validation

  • cargo test --locked -p codeql-rust config::tests (4 passed)
  • cargo clippy --locked -p codeql-rust --all-targets --no-deps -- -D warnings
  • cargo fmt --package codeql-rust --check
  • bazel build --nobuild //rust/extractor:single_arch/extractor (dependency analysis)
  • git diff --check

@github-actions github-actions Bot added the Rust Pull requests that update Rust code label Nov 9, 2026
@paldepind paldepind changed the title Rust: simplify extractor command-line options Rust: Simplify extractor command-line option parsing Nov 9, 2026
paldepind and others added 2 commits November 9, 2026 14:05
Replace the generated CLI configuration with explicit support for file-list, qltest, and logging-verbosity. Preserve configuration through environment variables and options.yml, and remove the unused macro crate and serde_with dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 03abd0ed-3880-4e39-8713-990a317c96e6
Remove generated Bazel definitions for the unused macro crate and serde_with dependencies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 03abd0ed-3880-4e39-8713-990a317c96e6
@paldepind
paldepind force-pushed the rust/extractor-cli-args branch from e4f2b2b to 2430806 Compare November 9, 2026 13:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant