[GHSA-29xr-v42j-r956] thenify before 3.3.1 made use of unsafe calls to eval.#7451
Open
Wenxin-Jiang wants to merge 1 commit intoWenxin-Jiang/advisory-improvement-7451from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
index.jsis a 32‑line file that only monkey-patchesArray.prototype.then / Array.prototype.catchon the global prototype.module.exports— the package has no callable export surface. You cannot pass a user-named function into it.thenify()function, nocreateWrapper(), and no eval / new Function anywhere in the source (confirmed: only unthenify matches the substring scan).fn.nameinto aneval('(function ' + name + '() {...})')template) literally does not exist in 1.0.0 — there is no code path that constructs source from any input, let alone user-controlled input.