Repository navigation
Conversation
I plan on switching from Jest to Vitest, to reduce recurring maintenance and dependency conflicts, and to align with sibling projects. Vitest 5.0.2 cannot run on Node.js 18; Node.js 24 meets its requirements and matches GitGitGadget's baseline. Assisted-by: GPT-6.1 Sol Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There can be more than one... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Jest upgrades, breakages and dependency conflicts keep demanding maintenance attention. Align with our sibling Node.js projects, including GitGitGadget, which already use Vitest. Only adapt the CommonJS mocking in tests so that the switch to vitest can be made without requiring major refactors. Assisted-by: GPT-6.1 Sol Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
requested review from
mjcheetham and
rimrul
and removed request for
mjcheetham
October 9, 2026 07:41
mjcheetham
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really sick and tired of all those Jest updates that fail and of all the incompatibilities because of CommonJS versus ECMAScript modules that are just making everything tedious with Jest, what with Jest being developed in a way conducive to reduce friction only with users inside their parent company.
By now, we have actually pretty good experience with Vitest. We switched away from Jest in other repositories, see e.g. the commit in the
setup-git-for-windows-sdkGitHub Action, where I, at first reluctantly, accepted that switch, in hindsight really appreciating the enormous reduction of developer friction.