Fix Windows CI flakes#1739
Open
svarlamov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
rev-parse --show-toplevelRoot cause
The linked Windows main failure was not caused by trace2 event nesting. The daemon test sync path spawned Git to resolve a family key after a Graphite command, and Windows intermittently failed that
rev-parsewith a.git/configpermission error while the repository was still hot from the command. That repo lookup does not need Git, and keeping it filesystem-only also avoids adding process work to the daemon path.A separate Windows shard failure in the same main run was a single remote reset from
https://example.com/in the native TLS cert test, so the test now treats that as an endpoint/network flake unless all trusted endpoints fail.Validation
task test CARGO_TEST_ARGS="--lib" TEST_FILTER=resolve_familytask test CARGO_TEST_ARGS="--test notes_sync_regression" TEST_FILTER=test_notes_sync_push_to_explicit_path_pushes_authorship_to_same_destinationtask test CARGO_TEST_ARGS="--test notes_sync_regression"task test CARGO_TEST_ARGS="--test integration" TEST_FILTER=tls_native_certs::test_https_request_uses_system_certstask test CARGO_TEST_ARGS="--test integration" TEST_FILTER=graphite::test_gt_pop_retains_working_treetask test TEST_FILTER=graphitetask fmttask lintgit diff --checktask testwith local/home/ubuntu/.opencode/binremoved fromPATHbecause this workstation has an unrelatedopencodebinary that makes an opencode detection test fail onmaintoo