Skip to content

Fix Windows CI flakes#1739

Open
svarlamov wants to merge 1 commit into
mainfrom
fix/windows-ci-flakes
Open

Fix Windows CI flakes#1739
svarlamov wants to merge 1 commit into
mainfrom
fix/windows-ci-flakes

Conversation

@svarlamov

@svarlamov svarlamov commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • resolve daemon family keys from filesystem repo-state data instead of spawning Git for rev-parse --show-toplevel
  • keep that resolver compatible with both worktree paths and bare/common-dir paths used by explicit push destinations
  • make the native TLS cert integration test retry across multiple trusted HTTPS endpoints before failing

Root cause

The linked Windows main failure was not caused by trace2 event nesting. The daemon test sync path spawned Git to resolve a family key after a Graphite command, and Windows intermittently failed that rev-parse with a .git/config permission error while the repository was still hot from the command. That repo lookup does not need Git, and keeping it filesystem-only also avoids adding process work to the daemon path.

A separate Windows shard failure in the same main run was a single remote reset from https://example.com/ in the native TLS cert test, so the test now treats that as an endpoint/network flake unless all trusted endpoints fail.

Validation

  • task test CARGO_TEST_ARGS="--lib" TEST_FILTER=resolve_family
  • task test CARGO_TEST_ARGS="--test notes_sync_regression" TEST_FILTER=test_notes_sync_push_to_explicit_path_pushes_authorship_to_same_destination
  • task test CARGO_TEST_ARGS="--test notes_sync_regression"
  • task test CARGO_TEST_ARGS="--test integration" TEST_FILTER=tls_native_certs::test_https_request_uses_system_certs
  • task test CARGO_TEST_ARGS="--test integration" TEST_FILTER=graphite::test_gt_pop_retains_working_tree
  • task test TEST_FILTER=graphite
  • task fmt
  • task lint
  • git diff --check
  • task test with local /home/ubuntu/.opencode/bin removed from PATH because this workstation has an unrelated opencode binary that makes an opencode detection test fail on main too

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@svarlamov svarlamov changed the title fix windows ci flakes Fix Windows CI flakes Jul 6, 2026
@svarlamov svarlamov marked this pull request as ready for review July 6, 2026 20:31

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant