Skip to content

fix(ci) - Agent v1 shell command CI break#1734

Merged
svarlamov merged 1 commit into
mainfrom
codex/fix-agent-v1-shell-command-ci
Jul 6, 2026
Merged

fix(ci) - Agent v1 shell command CI break#1734
svarlamov merged 1 commit into
mainfrom
codex/fix-agent-v1-shell-command-ci

Conversation

@Siddhant-K-code

@Siddhant-K-code Siddhant-K-code commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the current CI break caused by Agent v1 shell hook parsing, plus the follow-on CI failures exposed after that compile fix.

PreBashCall and PostBashCall require a command field, but the Agent v1 preset only stored shell commands in context metadata. That made main fail to build before tests could run.

Main CI context

Recent main merges around the break:

Related PRs checked

Changes

  • Populate PreBashCall.command and PostBashCall.command from Agent v1 shell hook payloads.
  • Keep the existing metadata value for compatibility.
  • Add parser assertions so the typed command field cannot be omitted again.
  • Use the SQLite memory-limited helper in Copilot OTEL/model-extraction test DB setup.
  • Initialize the metrics fallback database schema so Windows test daemons cannot poison the metrics singleton with an empty SQLite DB after fallback initialization.
  • Skip the PR smoke benchmark with a GitHub warning when the current branch builds but the main comparison baseline does not build.

Validation

  • task test TEST_FILTER=test_fallback_database_initializes_schema
  • task test TEST_FILTER=test_reset_hard_with_c_flag
  • task test TEST_FILTER=sqlite_connections_go_through_memory_limited_helpers
  • task test TEST_FILTER=copilot_otel
  • task test TEST_FILTER=agent_v1
  • task lint
  • task build
  • task fmt
  • python3 -m py_compile scripts/benchmarks/git/benchmark_nasty_modes_vs_main.py
  • Benchmark skip-path sanity run against current broken origin/main

@Siddhant-K-code Siddhant-K-code changed the title [codex] fix Agent v1 shell command CI break ci: fix Agent v1 shell command CI break Jul 6, 2026
@Siddhant-K-code Siddhant-K-code changed the title ci: fix Agent v1 shell command CI break fix(ci) - Agent v1 shell command CI break Jul 6, 2026
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review July 6, 2026 04:56

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@Siddhant-K-code Siddhant-K-code marked this pull request as draft July 6, 2026 04:58
@Siddhant-K-code Siddhant-K-code force-pushed the codex/fix-agent-v1-shell-command-ci branch from 680b873 to f4bc2a4 Compare July 6, 2026 05:00
@Siddhant-K-code Siddhant-K-code force-pushed the codex/fix-agent-v1-shell-command-ci branch from f4bc2a4 to 012a20c Compare July 6, 2026 05:54
@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review July 6, 2026 06:08
@svarlamov svarlamov merged commit be89a03 into main Jul 6, 2026
36 checks passed
@svarlamov svarlamov deleted the codex/fix-agent-v1-shell-command-ci branch July 6, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants