Add signed package installer scaffolding#1714
Open
Siddhant-K-code wants to merge 2 commits into
Open
Conversation
This was referenced Jul 1, 2026
a119dc6 to
5022b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first signed/package-manager installer implementation pass:
git-ai setup-package --manager <msi|pkg|apt|brew>for conservative per-user setup after package-manager installsgit/git.exeshim installationgit-ai.rbThis intentionally starts fresh instead of continuing
#1322: new installers must not install Git shims or interceptgit.Secrets/vars needed before production release
Apple:
Developer ID ApplicationandDeveloper ID Installercertificates from a CSR..cerinto Keychain, export each cert+private key as.p12, then base64 encode it..p8.Settings -> Secrets and variables -> Actions -> Secrets:APPLE_DEVELOPER_ID_APPLICATION_P12_BASE64APPLE_DEVELOPER_ID_APPLICATION_P12_PASSWORDAPPLE_DEVELOPER_ID_APPLICATION_IDENTITY(Developer ID Application: ...)APPLE_DEVELOPER_ID_INSTALLER_P12_BASE64APPLE_DEVELOPER_ID_INSTALLER_P12_PASSWORDAPPLE_DEVELOPER_ID_INSTALLER_IDENTITY(Developer ID Installer: ...)APPLE_NOTARY_KEY_IDAPPLE_NOTARY_ISSUER_IDAPPLE_NOTARY_KEY_P8_BASE64Azure Artifact Signing:
main(repo:git-ai-project/git-ai:ref:refs/heads/main).Artifact Signing Certificate Profile Signeron the signing account/profile.Settings -> Secrets and variables -> Actions -> Secrets:AZURE_CLIENT_IDAZURE_TENANT_IDAZURE_SUBSCRIPTION_IDSettings -> Secrets and variables -> Actions -> Variables:AZURE_ARTIFACT_SIGNING_ENDPOINTAZURE_ARTIFACT_SIGNING_ACCOUNTAZURE_ARTIFACT_SIGNING_CERT_PROFILEQuarantine cleanup
This PR does not remove the macOS
xattr -d com.apple.quarantinefallback frominstall.sh. Remove it only after a production release with signed macOS binaries and signed/notarized PKGs has shipped and fresh install/upgrade paths are verified.Validation
cargo fmttask test TEST_FILTER=package_setup CARGO_TEST_ARGS="--lib"task buildbash -n packaging/debian/build-deb.sh packaging/macos/build-pkg.sh packaging/homebrew/update-formula.sh packaging/debian/postinst packaging/debian/prerm packaging/macos/scripts/postinstall packaging/macos/scripts/preinstallpython3/PyYAMLtarget/debug/git-aitask lintLinear: PD-10
Supersedes #1322