-
Notifications
You must be signed in to change notification settings - Fork 230
Fix immediate stats after editor agent commits #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Siddhant-K-code
wants to merge
4
commits into
git-ai-project:main
Choose a base branch
from
Siddhant-K-code:siddhant/cursor-copilot-commit-stats-regressions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2d35dd6
Fix Cursor hook stdin decoding for CJK content
Siddhant-K-code 79aa8a1
Fix immediate stats after editor agent commits
Siddhant-K-code 1bd15ae
Merge branch 'main' into siddhant/cursor-copilot-commit-stats-regress…
Siddhant-K-code 4c75dc5
Merge branch 'main' into siddhant/cursor-copilot-commit-stats-regress…
Siddhant-K-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Identical daemon-sync helper is duplicated across two files instead of being shared
The daemon sync logic is copy-pasted verbatim into two separate private functions (
sync_daemon_before_stats_readatsrc/commands/git_ai_handlers.rs:1062andsync_daemon_before_status_readatsrc/commands/status.rs:218) differing only in a debug log string, rather than being extracted into a single reusable helper.Impact: Violates the repository's mandatory code-reuse rule and increases maintenance burden for any future changes to the sync logic.
AGENTS.md rule #5 violation details
AGENTS.md states: "Reuse existing code. This is a large codebase. For nearly any operation you need, there is almost certainly a helper function already available and tested. Reuse code as much as practical -- it also keeps diffs small. PRs that fail to reuse existing code where applicable will be rejected immediately."
Both functions have identical structure:
ControlRequest::SyncFamilywith the workdirsend_control_requestand handle Ok/ErrThe only difference is the debug log message ("stats" vs "status"). These should be a single shared function, possibly accepting a
&strcontext label for the debug message.src/commands/git_ai_handlers.rs:1062-1086is identical tosrc/commands/status.rs:218-242.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.