Repository navigation
feat(mypolitics): add universal axis task - #81
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33cbacf4d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| |---|---| | ||
| | Value below 0 or above 100 | Clamped into range | | ||
| | `start` + `end` values exceed 100 | Both fills scaled proportionally so they meet without overlapping | | ||
| | Value missing or not a number | Treated as an absent entry | |
There was a problem hiding this comment.
When an orientation is known but its score is unavailable, treating the entry as absent removes its cap and label and can incorrectly change a double-sided bar into a one-sided bar. The stated source of truth (mypolitics/spec/quiz/universal-axis.md, lines 36 and 96) instead requires the entry to remain present, render without a fill or number, and be announced as missing; AxisEntry.value should consequently be optional and the corresponding test should preserve the entry rather than discard it.
Useful? React with 👍 / 👎.
| - Use the standard colors palette, never add colors directly (check https://tailwindcss.com/docs/colors and our color palette in the `src/index.css` file and in [athena](https://github.com/gi-org-pl/athena/blob/main/src/index.css)) - the only exception is the author-supplied orientation colour described above | ||
| - Create unit tests with Vitest for 100% of the code created if feasible (check our [testing convention](https://github.com/Generacja-Innowacja/gi-tech-standards/blob/main/docs/frontend/conventions/TESTING_CONVENTION.md)) | ||
| - Create a Storybook story for the component with all possible props variants of the component | ||
| - Comply with [the component structure](https://github.com/Generacja-Innowacja/gi-tech-standards/blob/main/docs/frontend/conventions/COMPONENT_STRUCTURE.md) | ||
| - The image description and any other literal copy go through Lingui macros; orientation names and values come from props | ||
| - The PR follows the repository's pull request template: Changes, How to test, Visual Preview (screenshots of the one-sided and double-sided stories next to the Figma frame), Checklist |
There was a problem hiding this comment.
Add feature/universal-axis-60 to the task's standards and Definition of Done. The repository task template requires every task to specify {type}/{task-name}-{issue number} so work remains traceable to its issue, but this task omits the branch requirement entirely while the related tasks identify UniversalAxis as issue 60.
Useful? React with 👍 / 👎.
1 participant
No description provided.