Repository navigation
Console POC - #1
Conversation
Signed-off-by: Adrian Orłów <adrian@orlow.me>
Signed-off-by: Adrian Orłów <adrian@orlow.me>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 594bd11c35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - run: corepack enable | ||
| - run: yarn install --frozen-lockfile |
There was a problem hiding this comment.
On the declared Node 24 environment, corepack enable does not infer Yarn 1 from this repository: with Corepack 0.34.6 it resolves Yarn 4.14.1, and this exact install exits with This package doesn't seem to be present in your lockfile. Yarn's help confirms that --frozen-lockfile aliases --immutable, so Yarn 4 cannot migrate the committed v1 lockfile and the Pages workflow stops before typechecking or building. Pin Yarn 1 via packageManager or activate a specific 1.22 release before this step.
Useful? React with 👍 / 👎.
| const blob = await rasterizeGraphic(template, content, format); | ||
| if (isCancelled) return; |
There was a problem hiding this comment.
Every keystroke creates a new content object and starts another effect, but cancellation is checked only after rasterizeGraphic finishes. Rapidly entering a headline therefore runs one full 1080px rasterization per stale keystroke concurrently, followed by all four formats for the latest value; on the mobile devices this code explicitly targets, that can cause severe input lag or memory exhaustion. Delay starting the render until input settles, or serialize renders so stale work is discarded before invoking the rasterizer.
Useful? React with 👍 / 👎.
AdrianOrlow
changed the title
1 participant
N/A