Skip to content

ref(asgi): Deduplicate by removing _get_transaction_name_and_source() #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 1 commit into from
Oct 1, 2026
Merged

ref(asgi): Deduplicate by removing _get_transaction_name_and_source() #7813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions sentry_sdk/integrations/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ async def _run_app(
(
transaction_name,
transaction_source,
) = self._get_transaction_name_and_source(scope)
) = self._get_segment_name_and_source(scope)

method = scope.get("method", "").upper()

Expand Down Expand Up @@ -351,7 +351,7 @@ def event_processor(
]
)
if not already_set:
name, source = self._get_transaction_name_and_source(asgi_scope)
name, source = self._get_segment_name_and_source(asgi_scope)
event["transaction"] = name
event["transaction_info"] = {"source": source}

Expand All @@ -363,7 +363,7 @@ def event_processor(
# data to your liking it's recommended to use the `before_send` callback
# for that.

def _get_transaction_name_and_source(
def _get_segment_name_and_source(
self: "SentryAsgiMiddleware", asgi_scope: "Any"
) -> "Tuple[str, str]":
name = None
Expand Down Expand Up @@ -393,35 +393,3 @@ def _get_transaction_name_and_source(
return name, source

return name, source

def _get_segment_name_and_source(
self: "SentryAsgiMiddleware", asgi_scope: "Any"
) -> "Tuple[str, str]":
name = None
source = SegmentNameSource.ROUTE.value
ty = asgi_scope.get("type")

# FastAPI includes the route object in the scope to let Sentry extract the
# path from it for the transaction name
route = asgi_scope.get("route")
if route:
path = getattr(route, "path", None)
if path is not None:
name = path
else:
name = _get_url(
asgi_scope,
"http" if ty == "http" else "ws",
host=None,
path=_get_path(
asgi_scope=asgi_scope, root_path_in_path=self.root_path_in_path
),
)
source = SegmentNameSource.URL.value

if name is None:
name = _DEFAULT_TRANSACTION_NAME
source = SegmentNameSource.ROUTE.value
return name, source

return name, source
Loading