ref(sanic): Drop send_default_pii support - #7703
pabloDeputter wants to merge 7 commits into
Conversation
Codecov Results 📊✅ 62837 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65728 | Pass Rate: 95.6% | Execution Time: 174m 17s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
| {"send_default_pii": False}, | ||
| None, | ||
| id="send_default_pii_false", | ||
| {"data_collection": {"url_query_params": {"mode": "denylist", "terms": []}}}, |
There was a problem hiding this comment.
Same optional suggestion as #7705 (comment) -- we don't need the outer data_collection level since it's the same everywhere
There was a problem hiding this comment.
I flattened the test cases in tests/integrations/utils.py so data_collection can be passed directly, the postfix cases _LEGACY still uses the init_kwargs. I also updated aiohttp and arq tests to use the flattened version.
There was a problem hiding this comment.
and when merged, I'll update the other integrations so that the legacy cases can be removed
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3921844. Configure here.
3921844 to
e684644
Compare

Description
SanicRequestExtractorinherits fromRequestExtractorwhich still has somesend_default_piibranching, but this will be fixed in Remove send_default_pii from wsgi #7616.Issues
Resolves #7611