chore(ci): Streamline tarball packaging & e2e test matrix generation#20396
Draft
chore(ci): Streamline tarball packaging & e2e test matrix generation#20396
Conversation
Contributor
size-limit report 📦
|
2025a5d to
0ed38af
Compare
use correct nx version fix linting
This reverts commit e2107f0.
7912348 to
4481233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while working on other things, this was a bit more spread out then necessary:
With this PR, we instead have a proper step to build tarballs which are stored as artifacts (which should never fail), and which are also reused if needed at the end. The test matrix detection goes into the metadata job, so we can possibly also use it for other things.