feat(snapshots): Add --all-image-file-names and --all-image-file-names-file flags#3312
Open
NicoHinderling wants to merge 3 commits into
Open
feat(snapshots): Add --all-image-file-names and --all-image-file-names-file flags#3312NicoHinderling wants to merge 3 commits into
NicoHinderling wants to merge 3 commits into
Conversation
Contributor
|
NicoHinderling
force-pushed
the
feat/snapshots-all-image-file-names-manifest
branch
from
0b55bb0 to
5735d1c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…s-file flags Add two mutually exclusive flags to `snapshots upload` that allow selective builds to provide a complete list of image file names from the full test suite. The backend uses this list to distinguish genuinely removed images from images that were simply not included in a selective upload. - `--all-image-file-names <NAMES>` accepts a comma-separated list inline - `--all-image-file-names-file <PATH>` reads one name per line from a file - Either flag implicitly enables `--selective` - CLI validates that every discovered image appears in the list before uploading Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NicoHinderling
force-pushed
the
feat/snapshots-all-image-file-names-manifest
branch
from
5735d1c to
5ccaa62
Compare
Paths produced by tools like `find .` include a `./` prefix, but the internal relative paths do not. Strip the prefix from user-provided names so validation doesn't falsely reject valid images. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes clippy str_to_string lint in normalize_image_names and its test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two mutually exclusive flags to
snapshots uploadthat allow selectivebuilds to provide a complete list of image file names from the full test suite.
The backend uses this list to distinguish genuinely removed images from images
that were simply not included in a selective upload.
--all-image-file-names <NAMES>accepts a comma-separated list inline--all-image-file-names-file <PATH>reads one name per line from a file--selectiveCompanion to sentry#113006
which adds the backend support for
all_image_file_names.Follows up on #3268
which added the
--selectiveflag.