Skip to content

fix: Bind Getsantry approvals to actor identity and allowed targets - #9797

Merged
BYK merged 1 commit into
mainfrom
fix-getsantry-approvals
Oct 7, 2026
Merged

BYK merged 1 commit into
mainfrom
fix-getsantry-approvals

Conversation

@BYK

@BYK BYK commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Accept getsantry[bot] approvals for exact auto-approve-repos.txt repository/path entries; reject other targets, including changed requests.
  • Require the exact GitHub bot login, stable numeric actor ID, and Bot type for both Getsantry and Junior at the initial label event and subsequent live-event checks. GitHub issue label events expose actor IDs but no performing-App/installation ID.
  • Retain Junior's existing target scope and human write/admin checks.

Validation

  • Fail-first regressions covered the publish: getsentry/sentry-protos@0.81.1 #9788 Getsantry event, swapped/missing bot IDs, lookalike actors, changed targets, and malformed paths.
  • pnpm test -- --printConsoleTrace: 18 files, 148 tests passed.
  • pnpm lint, Prettier checks, generated-parser check, workflow YAML parsing, and git diff --check passed.

Fixes #9772
Refs #9788, #9786

@BYK
BYK requested a review from a team as a code owner October 7, 2026 19:13
@BYK
BYK merged commit 2ab2d06 into main Oct 7, 2026
14 checks passed
@BYK
BYK deleted the fix-getsantry-approvals branch October 7, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow trusted sentry-authored bots to approve releases

2 participants