Repository navigation
fix: optimize the renderer by using child map in virtual dom - #81
Open
bchelkowski wants to merge 2 commits into
Open
bchelkowski wants to merge 2 commits into
bchelkowski wants to merge 2 commits into
Conversation
bchelkowski
requested review from
kamil-dazn and
saikiranreddydavu
and removed request for
a team
July 17, 2026 13:25
- store the normalised virtual DOM before componentDidMount so a synchronous forceUpdate() from there no longer re-renders the whole tree - mark children maps with an explicit __childrenMap/byId structure instead of detecting them by a missing name field, so child ids like 'name' or 'count' cannot break collection detection or shadow AA methods - assign dense order values (skipping Invalid and dropped children) so insertChild indexes are not shifted by conditionally hidden children - recurse into children when marking id-less elements for removal, so switching the render output shape no longer leaks the previous subtree - warn about children with missing or duplicated props.id instead of silently dropping them; duplicated ids keep the position of the first occurrence - expose normaliseVNode as a public KopytkoDiffUtility method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.