Skip to content

Preserve one-off fee period dates - #6198

Draft
lago-claude-ai-agent[bot] wants to merge 3 commits into
mainfrom
fix/claude-preserve-one-off-fee-period-dates
Draft

Preserve one-off fee period dates#6198
lago-claude-ai-agent[bot] wants to merge 3 commits into
mainfrom
fix/claude-preserve-one-off-fee-period-dates

Conversation

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor

Add-on and one-off fee periods now keep the calendar dates expressed by offset-bearing timestamps in CSV exports and invoice detail responses, matching invoice PDFs. Frontend write-path normalization remains out of scope.

## Context

Offset-bearing one-off fee periods could display different calendar dates across invoice surfaces.

## Description

Preserve the dates expressed by add-on timestamps in exports and invoice details.

Signed-off-by: lago-claude-ai-agent[bot] <297187938+lago-claude-ai-agent[bot]@users.noreply.github.com>
@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author

Held: CI is not green on this PR; not reviewed. Re-run CI, then re-review.

Checks: https://github.com/getlago/lago-api/pull/6198/checks

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author

Impediment

Where I stopped: I stopped at validation and restored this revise pass's working-tree edits.

Why: The required full bundle exec rubocop exits with five unrelated existing offenses, and the required lago exec api bundle exec rspec ... command cannot run because the lago executable and API container are unavailable.

What would unblock me: Provide a checkout with a green full RuboCop baseline and the lago launcher plus API container available for the required focused specs.

Signed-off-by: lago-claude-ai-agent[bot] <297187938+lago-claude-ai-agent[bot]@users.noreply.github.com>
@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author
  • Read/display scope: limited calendar-date handling to add-on fee CSV exports and invoice-detail GraphQL, preserved create timestamps, and covered a negative-offset period.

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author

HOLD: invoice-detail mode is stored in query-global GraphQL context, so it can leak to unrelated sibling fields in the same operation.

  • Use scoped context and add a mixed-root regression spec so only descendants of the single-invoice field preserve add-on calendar dates.
  • Remove the unrelated item_metadata.rb schema-comment churn.
  • Amend or squash the second commit to include the required ## Context and ## Description body.

## Context

Invoice-detail formatting used query-global context and could affect add-on periods returned by sibling root fields.

## Description

Scope formatting to the single-invoice field, cover sibling isolation, and restore unrelated schema annotations.

Signed-off-by: lago-claude-ai-agent[bot] <297187938+lago-claude-ai-agent[bot]@users.noreply.github.com>
@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author
  • Invoice detail: switched to scoped context and added a mixed-root regression proving sibling isolation.
  • Schema comments: restored the unrelated item metadata annotations.
  • Read/display scope: left creation, PDF output, and non-add-on periods unchanged.
  • Commit format: supplied the required Context and Description sections for the driver-created follow-up.

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor Author

HOLD: amend or squash fix(invoices): Preserve detail fee dates so that commit itself includes the required ## Context and ## Description sections; the later compliant commit does not repair the noncompliant history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants