Skip to content

treat missing git as inspect-failed instead of not-a-repo #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedhruvhegde wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

treat missing git as inspect-failed instead of not-a-repo #3141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/runtimes/workspace-registry/node/inspect-path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export async function inspectWorkspacePath(
}));
} catch (error) {
// Exit 128 = not inside a git work tree: a plain directory, not a failure.
if (error instanceof ExecError && error.exitCode !== null) return { kind: 'directory' };
if (error instanceof ExecError && error.exitCode === 128) return { kind: 'directory' };

@greptile-apps greptile-apps Bot Sep 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Exit 128 Is Ambiguous

Git also returns exit code 128 for fatal errors such as permission failures. In those cases, this branch classifies an inaccessible or broken repository as a plain directory instead of inspect-failed, so the workspace registry can accept it without surfacing the inspection error. The existing Git runtime avoids this by matching known non-repository messages rather than relying only on the exit code.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/core/src/runtimes/workspace-registry/node/inspect-path.ts
Line: 49

Comment:
**Exit 128 Is Ambiguous**

Git also returns exit code 128 for fatal errors such as permission failures. In those cases, this branch classifies an inaccessible or broken repository as a plain directory instead of `inspect-failed`, so the workspace registry can accept it without surfacing the inspection error. The existing Git runtime avoids this by matching known non-repository messages rather than relying only on the exit code.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

return {
kind: 'inspect-failed',
message: error instanceof Error ? error.message : String(error),
Expand Down