linux: drop macos dialog message and allow creating folders - #3139
linux: drop macos dialog message and allow creating folders#3139thedhruvhegde wants to merge 1 commit into
Conversation
…lders in the directory picker. closes generalaction#2336
Greptile SummaryThis PR makes native open-dialog options platform-specific for directory and audio-file selection.
Confidence Score: 4/5The PR should not merge until the directory-creation implementation is corrected because the targeted Linux workflow remains unfixed. The message handling matches Electron's platform contract, but the new Files Needing Attention: apps/emdash-desktop/src/main/core/app/service.ts
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/main/core/app/service.ts | Introduces platform-specific dialog options, with createDirectory guarded for the platforms where Electron does not support it. |
Prompt To Fix All With AI
### Issue 1
apps/emdash-desktop/src/main/core/app/service.ts:609-612
**Unsupported folder creation option**
Electron's `createDirectory` option is macOS-only, but this branch adds it only on Linux and Windows, where it is ignored, and omits it on macOS, where it is supported. As a result, the directory picker still cannot create folders in the targeted Linux flow, so the reported bug remains unresolved.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "stop passing macos-only dialog message o..." | Re-trigger Greptile
| properties: | ||
| process.platform === 'darwin' | ||
| ? ['openDirectory'] | ||
| : ['openDirectory', 'createDirectory'], |
There was a problem hiding this comment.
Unsupported folder creation option
Electron's createDirectory option is macOS-only, but this branch adds it only on Linux and Windows, where it is ignored, and omits it on macOS, where it is supported. As a result, the directory picker still cannot create folders in the targeted Linux flow, so the reported bug remains unresolved.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/emdash-desktop/src/main/core/app/service.ts
Line: 609-612
Comment:
**Unsupported folder creation option**
Electron's `createDirectory` option is macOS-only, but this branch adds it only on Linux and Windows, where it is ignored, and omits it on macOS, where it is supported. As a result, the directory picker still cannot create folders in the targeted Linux flow, so the reported bug remains unresolved.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
summary
electron on linux does not support
messageonshowOpenDialog, so the directory picker could fail or look broken.createDirectorywas also false, so you could not make a new folder from the picker.message stays on darwin. linux/win get
createDirectory: truewithout that option.closes #2336
test plan