Skip to content

set StartupWMClass for gnome dock grouping #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedhruvhegde wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

set StartupWMClass for gnome dock grouping #3133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/emdash-desktop/electron-builder.canary.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ const config: Configuration = {
category: 'Development',
executableName: APP_NAME_LOWER,
icon: 'src/assets/images/emdash/emdash-canary.png',
desktop: {
StartupWMClass: PRODUCT_NAME,
},
target: [
{ target: 'AppImage', arch: ['x64'] },
{ target: 'deb', arch: ['x64'] },
Expand Down
3 changes: 3 additions & 0 deletions apps/emdash-desktop/electron-builder.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ const config: Configuration = {
linux: {
category: 'Development',
icon: 'src/assets/images/emdash/emdash.png',
desktop: {
StartupWMClass: PRODUCT_NAME,
},
Comment on lines +66 to +68

@greptile-apps greptile-apps Bot Sep 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Desktop Entry Field Misnested

StartupWMClass is placed directly under linux.desktop, but electron-builder 26 expects custom desktop-entry fields under linux.desktop.entry. As a result, the stable and canary Linux launchers will not emit this value as intended, so GNOME window grouping remains broken. Please nest the field under desktop.entry in both configurations.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/emdash-desktop/electron-builder.config.ts
Line: 66-68

Comment:
**Desktop Entry Field Misnested**

`StartupWMClass` is placed directly under `linux.desktop`, but electron-builder 26 expects custom desktop-entry fields under `linux.desktop.entry`. As a result, the stable and canary Linux launchers will not emit this value as intended, so GNOME window grouping remains broken. Please nest the field under `desktop.entry` in both configurations.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

target: [
{ target: 'AppImage', arch: ['x64'] },
{ target: 'deb', arch: ['x64'] },
Expand Down