Skip to content

Add missing libgearman protocol tests #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esabol merged 2 commits into from
Oct 11, 2026
Merged

Add missing libgearman protocol tests #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c272ea1
Add missing libgearman protocol tests.
esabol Oct 8, 2026
d660d23
Add comprehensive checks for gearmand_command_info_list table.
esabol Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 64 additions & 1 deletion tests/libgearman-1.0/internals.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ struct internal_test_st

internal_test_st() :
gearmand_pid(-1)
{
{
}

~internal_test_st()
Expand Down Expand Up @@ -440,6 +440,68 @@ test_st packet_st_test[] ={
{0, 0, 0}
};

static test_return_t command_info_table_test(void *)
{
// Verify that the code for every entry in gearmand_command_info_list[]
// matches its index.
for (int cmd= 0; cmd < int(GEARMAN_COMMAND_MAX); ++cmd)
{
ASSERT_EQ(cmd, int(gearman_command_info(gearman_command_t(cmd))->code));
}

// Verify the argc value for every entry in gearmand_command_info_list[].
ASSERT_EQ(5, gearman_command_info(GEARMAN_COMMAND_TEXT)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_CAN_DO)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_CANT_DO)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_RESET_ABILITIES)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_PRE_SLEEP)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_UNUSED)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_NOOP)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_JOB_CREATED)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_GRAB_JOB)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_NO_JOB)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_JOB_ASSIGN)->argc);
ASSERT_EQ(3, gearman_command_info(GEARMAN_COMMAND_WORK_STATUS)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_WORK_COMPLETE)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_WORK_FAIL)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_GET_STATUS)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_ECHO_REQ)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_ECHO_RES)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_BG)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_ERROR)->argc);
ASSERT_EQ(5, gearman_command_info(GEARMAN_COMMAND_STATUS_RES)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_HIGH)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_SET_CLIENT_ID)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_CAN_DO_TIMEOUT)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_ALL_YOURS)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_WORK_EXCEPTION)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_OPTION_REQ)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_OPTION_RES)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_WORK_DATA)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_WORK_WARNING)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_GRAB_JOB_UNIQ)->argc);
ASSERT_EQ(3, gearman_command_info(GEARMAN_COMMAND_JOB_ASSIGN_UNIQ)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_HIGH_BG)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_LOW)->argc);
ASSERT_EQ(2, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_LOW_BG)->argc);
ASSERT_EQ(7, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_SCHED)->argc);
ASSERT_EQ(3, gearman_command_info(GEARMAN_COMMAND_SUBMIT_JOB_EPOCH)->argc);
ASSERT_EQ(4, gearman_command_info(GEARMAN_COMMAND_SUBMIT_REDUCE_JOB)->argc);
ASSERT_EQ(4, gearman_command_info(GEARMAN_COMMAND_SUBMIT_REDUCE_JOB_BACKGROUND)->argc);
ASSERT_EQ(0, gearman_command_info(GEARMAN_COMMAND_GRAB_JOB_ALL)->argc);
ASSERT_EQ(4, gearman_command_info(GEARMAN_COMMAND_JOB_ASSIGN_ALL)->argc);
ASSERT_EQ(1, gearman_command_info(GEARMAN_COMMAND_GET_STATUS_UNIQUE)->argc);
ASSERT_EQ(6, gearman_command_info(GEARMAN_COMMAND_STATUS_RES_UNIQUE)->argc);

return TEST_SUCCESS;
}

test_st command_info_tests[] ={
{"gearmand_command_info_list table", 0, command_info_table_test },
{0, 0, 0}
};

test_st regression_tests[] ={
{"lp:783141, multiple calls for bad host", 0, regression_bug_783141_test },
{"lp:372074", 0, regression_bug_372074_test },
Expand All @@ -450,6 +512,7 @@ collection_st collection[] ={
{"gearman_universal_st", 0, 0, universal_st_test},
{"gearman_connection_st", 0, 0, connection_st_test},
{"gearman_packet_st", 0, 0, packet_st_test},
{"gearmand_command_info_list", 0, 0, command_info_tests},
{"regression", 0, 0, regression_tests},
{0, 0, 0, 0}
};
Expand Down
23 changes: 13 additions & 10 deletions tests/libgearman-1.0/protocol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ using namespace libtest;

test_return_t check_gearman_command_t(void *)
{
ASSERT_EQ(0, int(GEARMAN_COMMAND_TEXT));
ASSERT_EQ(1, int(GEARMAN_COMMAND_CAN_DO));
ASSERT_EQ(2, int(GEARMAN_COMMAND_CANT_DO));
ASSERT_EQ(3, int(GEARMAN_COMMAND_RESET_ABILITIES));
ASSERT_EQ(4, int(GEARMAN_COMMAND_PRE_SLEEP));
ASSERT_EQ(5, int(GEARMAN_COMMAND_UNUSED));
ASSERT_EQ(6, int(GEARMAN_COMMAND_NOOP));
ASSERT_EQ(7, int(GEARMAN_COMMAND_SUBMIT_JOB));
ASSERT_EQ(8, int(GEARMAN_COMMAND_JOB_CREATED));
ASSERT_EQ(9, int(GEARMAN_COMMAND_GRAB_JOB));
ASSERT_EQ( 0, int(GEARMAN_COMMAND_TEXT));
ASSERT_EQ( 1, int(GEARMAN_COMMAND_CAN_DO));
ASSERT_EQ( 2, int(GEARMAN_COMMAND_CANT_DO));
ASSERT_EQ( 3, int(GEARMAN_COMMAND_RESET_ABILITIES));
ASSERT_EQ( 4, int(GEARMAN_COMMAND_PRE_SLEEP));
ASSERT_EQ( 5, int(GEARMAN_COMMAND_UNUSED));
ASSERT_EQ( 6, int(GEARMAN_COMMAND_NOOP));
ASSERT_EQ( 7, int(GEARMAN_COMMAND_SUBMIT_JOB));
ASSERT_EQ( 8, int(GEARMAN_COMMAND_JOB_CREATED));
ASSERT_EQ( 9, int(GEARMAN_COMMAND_GRAB_JOB));
ASSERT_EQ(10, int(GEARMAN_COMMAND_NO_JOB));
ASSERT_EQ(11, int(GEARMAN_COMMAND_JOB_ASSIGN));
ASSERT_EQ(12, int(GEARMAN_COMMAND_WORK_STATUS));
Expand Down Expand Up @@ -92,6 +92,9 @@ test_return_t check_gearman_command_t(void *)
ASSERT_EQ(38, int(GEARMAN_COMMAND_SUBMIT_REDUCE_JOB_BACKGROUND));
ASSERT_EQ(39, int(GEARMAN_COMMAND_GRAB_JOB_ALL));
ASSERT_EQ(40, int(GEARMAN_COMMAND_JOB_ASSIGN_ALL));
ASSERT_EQ(41, int(GEARMAN_COMMAND_GET_STATUS_UNIQUE));
ASSERT_EQ(42, int(GEARMAN_COMMAND_STATUS_RES_UNIQUE));
ASSERT_EQ(43, int(GEARMAN_COMMAND_MAX)); /* end of command table sentinel */

return TEST_SUCCESS;
}
Loading