Issue 7290: removed duplicate tableProperties instance - #7678
Conversation
|
|
||
| // When | ||
| List<Row> filtered = applyIterator(rows, tablePropertiesNullableValueField); | ||
| List<Row> filtered = applyIterator(rows, tableProperties); |
There was a problem hiding this comment.
Thanks very much for the help. Now that there's only one TableProperties field we don't need it to be a parameter for the helper methods any more. Do you want to update applyIterator and createIterator as part of this PR, or should we make that a separate issue?
There was a problem hiding this comment.
I would be happy to have a look at that later today! I will hopefully have a pull request posted
by tomorrow
There was a problem hiding this comment.
I added another commit that changes the function signature of applyIterator and createIterator to remove the redundant parameters.
I also noticed that with the new changes, it may be worth changing the function names, so it is easier to interpret its behaviour.
Previously you could infer the intent was to create an iterator for the tableProperties field, as the function call would include "tableProperties". However the function signature change now obscures this behaviour, requiring manual inspection of the function to interpret the behaviour.
Unfortunately I am now unavailable for the next two weeks, so to streamline the process I did not include this change, as it may require further input from me.
There was a problem hiding this comment.
I see what you mean. I'd be happy with that, or if you preferred to leave applyIterator and createIterator as they were. I think we can go ahead with what we've got, thanks.
…and AggregationFilteringIteratorTest.applyIterator to remove redundant parameters
Issue
Tests
Documentation