Add OCM release notes when updating gardener images#1656
Conversation
gardener-prow
Bot
added
do-not-merge/needs-kind
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
size/M
| f.write("\n") | ||
|
|
||
|
|
||
| def write_ocm_release_notes( |
There was a problem hiding this comment.
oci_client_ duplicates the oci_api client already created in main() — consider passing it in as a parameter to avoid a second connection pool.
| images_data.sort_images() | ||
| write_yaml_file(images_data, args.images_yaml_path, updated_directives) | ||
| print(f"\nUpdated {args.images_yaml_path} with {len(updates)} changes.", file=sys.stderr) | ||
| write_ocm_release_notes(updates, images_data) |
There was a problem hiding this comment.
write_ocm_release_notes is called inside if updates: but create_release_notes is called unconditionally within the outer if all_new_versions: block — the guards are inconsistent.
There was a problem hiding this comment.
create_release_notes does nothing when updates is empty (it returns early).
But you are right, the inconsistency is confusing.
I added create_release_notes and its print into the same if updates path.
ccwienk
removed
the
do-not-merge/needs-kind
df7843a to
66598e1
Compare
|
Thanks for the review @ccwienk! 🚀 |
2 participants
Release note: