feat(watch): classify dir-watch files as static share vs live watch - #131
Merged
Merged
Conversation
On dir-share adopt, classify each new markdown file as a live watch or a static share. Stamp an additive type label on new hosted shares. Closes #130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
dir-shareadopt, classify each new.mdfor likelihood of change:CreateShare(..., watch=false)). Do not register a child file watch. Appears ingander list, notgander status.status: draft→ live watch (watch=true+registerFile).New hosted shares also get an additive type label (
plan,rfc,draft,design,spec,report) merged into the existing label set.--no-labelsstays empty; an existing reserved type is not swapped.gander watch ~/reportsis unchanged as the directory command; classification is per file. Localdir-localstays always-watch. Explicitgander watch report.mdstill watches (the user asked) but may still get labelreport.MCP instructions tell agents to pick
gander share --silentvsgander watch --silentfrom the same table for files, and not to double-gander a dir-watched tree or send--label <type>.Closes #130
Test plan
go test ./...go vet ./...go build ./...reports/static,plans/+status: draftwatch,reports/draft-rfc.mdwatch (watch-signal wins), unknown README watch with no type,gander: shareforces static underplans/plan(+ project if inferred);--label review→reviewandplan; existing type not swapped;--no-labelssends[]; existing share omits labelsregisterFile; watch adopt does;dir-localalways registers