Skip to content

Pin Windows CI to windows-2022 for VS2022 matrix jobs#3622

Merged
gabime merged 3 commits into
v1.xfrom
copilot/fix-github-actions-job-failure
Jun 13, 2026
Merged

Pin Windows CI to windows-2022 for VS2022 matrix jobs#3622
gabime merged 3 commits into
v1.xfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The Windows workflow matrix entry build (Visual Studio 17 2022, Release, ON, ON, ON, ON, OFF, ON, 20) failed during CMake configure because windows-latest moved to an image without Visual Studio 2022. This change restores generator/runtime compatibility for the existing matrix configuration.

  • Root cause

    • Workflow requested CMake generator Visual Studio 17 2022.
    • Runner label windows-latest resolved to a newer image lacking VS2022.
  • Change

    • Updated .github/workflows/windows.yml:
      • runs-on: windows-latestruns-on: windows-2022
    • No matrix values or build flags were changed.
  • Effect

    • Keeps current Windows build matrix semantics intact.
    • Ensures jobs using -G "Visual Studio 17 2022" run on a compatible hosted image.
jobs:
  build:
    runs-on: windows-2022
    strategy:
      matrix:
        config:
          - GENERATOR: "Visual Studio 17 2022"

Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (Visual Studio 17 2022) Pin Windows CI to windows-2022 for VS2022 matrix jobs Jun 13, 2026
Copilot AI requested a review from gabime June 13, 2026 16:05
@gabime gabime marked this pull request as ready for review June 13, 2026 16:28
@gabime gabime merged commit 4800ae0 into v1.x Jun 13, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants