Skip to content

Make stdout sink _get_osfhandle exception message namespace-agnostic#3617

Draft
Copilot wants to merge 2 commits into
v1.xfrom
copilot/fix-code-review-suggestion
Draft

Make stdout sink _get_osfhandle exception message namespace-agnostic#3617
Copilot wants to merge 2 commits into
v1.xfrom
copilot/fix-code-review-suggestion

Conversation

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This addresses the targeted review feedback to update only comment r3353786308. The hard-coded spdlog:: prefix in a stdout_sink_base exception message was made namespace-agnostic to align with SPDLOG_NAMESPACE overrides.

  • Change

    • Updated the Windows-path exception text in include/spdlog/sinks/stdout_sinks-inl.h to remove the hard-coded namespace prefix.
  • Why this matters

    • Prevents misleading error text when spdlog is compiled under a custom namespace.
// before
throw_spdlog_ex("spdlog::stdout_sink_base: _get_osfhandle() failed", errno);

// after
throw_spdlog_ex("stdout_sink_base: _get_osfhandle() failed", errno);

Copilot AI changed the title [WIP] Fix code based on review comment Make stdout sink _get_osfhandle exception message namespace-agnostic Jun 4, 2026
Copilot finished work on behalf of gabime June 4, 2026 05:57
Copilot AI requested a review from gabime June 4, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants