test: update civic aac test fixtures#413
Conversation
|
To come back to this at some point... |
| name: Rearrangement | ||
| system: https://civicdb.org/links/variant/ | ||
| relation: exactMatch | ||
| name: MYBL1 Rearrangement |
There was a problem hiding this comment.
@ahwagner Is this fine? For variants the variation-normalizer can't normalize we don't have any constraints/members
There was a problem hiding this comment.
That's fine, but let's also add an extension that flags this case explicitly.
CategoricalVariationType: "Undefined"; also for ones that do normalize, let's indicate type as ProteinSequenceConsequence, CanonicalAllele, etc.
ahwagner
left a comment
ahwagner
left a comment
There was a problem hiding this comment.
LGTM, with note for VA-spec co-leads.
| extensions: | ||
| - name: aliases | ||
| value: | ||
| - BRAF Inhibitor GSK2118436 | ||
| - Benzenesulfonamide, N-(3-(5-(2-amino-4-pyrimidinyl)-2-(1,1-dimethylethyl)-4-thiazolyl)-2-fluorophenyl)-2,6-difluoro- | ||
| - GSK 2118436 | ||
| - GSK 2118436A | ||
| - GSK-2118436 | ||
| - GSK-2118436A | ||
| - GSK2118436 | ||
| - GSK2118436A |
There was a problem hiding this comment.
@korikuzma this is good based on current model.
@mbrush and @larrybabb note this issue with mappable concept as an Element instead of a Entity. Entities have aliases, elements do not. Comes back to discussion about what a MappableConcept should be.
3 participants
Generated from civicpy (manually added: mane extensions since it's on a separate branch, citations mapping, reported in).
@ahwagner here are the updated AAC representations. Since it's been a while since we discussed, wanted to see if there's any additional changes we should make with representing AAC statements in CIViCpy.
I would recommend looking at the following to confirm that this is how CIViC AAC data should be represented:
The other 2 files not listed are the simple versions of diagnostic and therapeutic