Settings: Network drive — Samba sign-in details and simple connect guides - #43
Merged
Merged
Conversation
FxCopyButton did `onPress={async () => onCopied?.(await copy(value))}`. An
optional call skips evaluating its arguments when the callee is undefined, so
every FxCopyButton without an `onCopied` prop never copied anything: CopyRow
(peer ids, wallet address), LinkPassword (DID), Requirements and LanErrorCard
(Chrome settings URL). Copy first, then report the result.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E9tV7663sXt1NFiCzM47wy
`blockchain.nasCredentials(bloxPeerId?)` calls go-fula's `nas-credentials`
(go-fula #250) with `{blox_peer_id}` and returns the Blox's Samba sign-in
details. Unlike the react-native-fula ports it rejects (HTTP_ERROR with
.status 404 not set up / 400 / 503 / 500, NOT_AUTHORIZED, BAD_RESPONSE) and
never returns or logs a raw body, because the response holds a password.
Tests: wire name / body / statuses, and fake-Blox end-to-end cases for 200,
400 mismatch, 404, a garbage 200 body and an unauthorized identity, asserting
the password never reaches the debug log.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E9tV7663sXt1NFiCzM47wy
…ides The firmware (fula-ota #98) gives every Blox a login-only Samba share with a per-device password; this screen lets a non-technical owner use it: - /settings/network-drive, reachable from a new "Network drive" card on the Blox dashboard and from Settings (after Pools). - Sign-in details (address, user name, password hidden until "Show") with Copy buttons, then 3-5 plain steps for Windows, Mac, iPhone/iPad and Android, preselected from the device (an iPad reporting a Mac user agent gets the iPhone/iPad guide). Mac also gets an "Open in Finder" smb:// button. - Addresses: Windows uses \\NAME\SharedFolder (the IP when there is more than one Blox or the name is not NetBIOS-safe); Mac/iPhone/Android use smb://IP/SharedFolder from what the app already knows about the Blox's LAN address. Never `.local` (the Blox has no mDNS). - "Can't connect?" tips per device, a one-line safety note, and plain states for connecting / loading / not set up yet / update needed / owner only / busy / offline. - The password lives only in the screen's state: never persisted, logged or toasted, cleared on Blox switch and unmount. CopyRow gains a `secret` mode that keeps the value out of the DOM (incl. title / data-value) until shown. - en + zh strings (zh machine-translated, OS control names in the real Windows/macOS/iOS wording — please have a native speaker review). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E9tV7663sXt1NFiCzM47wy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Network drive screen so a non-technical owner can use their Blox as a NAS. The firmware (fula-ota #98, go-fula #250) already turns on a login-only Samba share with a per-device password; the app now shows the sign-in details and walks the user through connecting.
/settings/network-drive).\\NAME\SharedFolder(IP when there's more than one Blox); Mac / iPhone / Androidsmb://IP/SharedFolder. Never.local(the Blox has no mDNS).Also fixed
FxCopyButtonnever copied without anonCopiedprop (onCopied?.(await copy(value))short-circuits its argument). This affected everyCopyRow(peer ids, wallet address), the DID copy in LinkPassword, and the Chrome-settings copy buttons.Client
fula-web-client:blockchain.nasCredentials(bloxPeerId?)→ go-fulanas-credentials; rejects with typed errors, never logs the body.Tests
npm run typecheck,npm run lint,npm test(fula-web-client 65, fx-ui incl. new copy-button tests, app 1016 tests / 108 files),npm run build, Playwright e2e 88 passed (route loads clean on desktop + Android profiles).Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01E9tV7663sXt1NFiCzM47wy