fix(#2193): auto-patch .gitlint to exempt bot authors during repo enrollment#2194
fix(#2193): auto-patch .gitlint to exempt bot authors during repo enrollment#2194fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…ollment The code agent's GitHub noreply email produces Signed-off-by trailers that inherently exceed 72 characters, failing gitlint body-max-line-length rules in onboarded repos. This required manual .gitlint patching by human maintainers on every enrollment PR. Add patch_gitlint_content and patch_gitlint_on_branch functions to reconcile-repos.sh that detect .gitlint in target repos during enrollment and automatically add fullsend bot usernames to the ignore-by-author-name regex. The patch is idempotent (skips repos that already have the exemption) and non-fatal (logs warnings on API failures without blocking enrollment). Three new test cases cover: adding the section when absent, appending to an existing regex, and idempotent no-op when bots are already exempt. Closes #2193
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Site previewPreview: https://6f28231b-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:39 PM UTC · Completed 7:52 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Info
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
LGTM. One non-blocking note inline.
| FAILED=$((FAILED + 1)) | ||
| continue | ||
| fi | ||
| patch_gitlint_on_branch "$REPO" "$ENROLL_BRANCH" |
There was a problem hiding this comment.
[moderate, non-blocking] Already-enrolled repos whose shim is current hit continue above and skip this. For backfilling those repos, we could run the gitlint check independently of shim state, or just bump the shim template to force everything through this path.
|
Oh, actually - I don't like this either, but for a different reason! First, the I think this issue got filed because those Author settings were propagating to the Signed-off-by trailer, making it too long, causing gitlint to fail, but.... That's a problem! Bots should never provide
|
|
🤖 Finished Retro · ✅ Success · Started 3:49 PM UTC · Completed 3:57 PM UTC |
Retro: PR #2194 — auto-patch .gitlint to exempt bot authorsOutcome: Closed without merging. 649 lines of wasted work. Timeline:
Root cause: The code agent solved the symptom (gitlint rejects long lines) rather than the root cause (bots shouldn't use Existing issue coverage: Several open issues already address the general patterns observed here:
One novel proposal below targets a specific, detectable anti-pattern not covered by existing issues. Proposals filed
|
2 participants
The code agent's GitHub noreply email produces Signed-off-by trailers that inherently exceed 72 characters, failing gitlint body-max-line-length rules in onboarded repos. This required manual .gitlint patching by human maintainers on every enrollment PR.
Add patch_gitlint_content and patch_gitlint_on_branch functions to reconcile-repos.sh that detect .gitlint in target repos during enrollment and automatically add fullsend bot usernames to the ignore-by-author-name regex. The patch is idempotent (skips repos that already have the exemption) and non-fatal (logs warnings on API failures without blocking enrollment).
Three new test cases cover: adding the section when absent, appending to an existing regex, and idempotent no-op when bots are already exempt.
Closes #2193
Post-script verification
agent/2193-gitlint-bot-exemption)a029a60d692add2778a1c13ed376d5fa1b5d8aef..HEAD)