Skip to content

jvm update to 17 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mykyta-frontegg wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −8
Open

jvm update to 17 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

kotlinOptions {
jvmTarget = "11"
jvmTarget = "17"
}
}

Expand Down
9 changes: 6 additions & 3 deletions docs/advanced.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,16 @@ Passkeys provide a seamless, passwordless login experience using WebAuthn and pl
}
```

3. Inside the `android` block, add the following to set Java 8 compatibility:
3. Inside the `android` block, set JVM 17 compatibility (required for React Native 0.80+ and AGP 8.x; use AGP 7.4+ if upgrading from older toolchains):

```groovy
android {
compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = "17"
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The Frontegg React Native SDK automatically handles token refresh behind the sce

### Supported platforms
- iOS: Deployment target 14.0 or higher
- Android: Minimum SDK version 26 (Android 8.0)
- Android: Minimum SDK version 26 (Android 8.0); **JDK 17** and **AGP 7.4+** for the Android toolchain (required by React Native 0.80+ and AGP 8.x)
- React Native: Version 0.63+ (recommended for best compatibility)
- WebAuthn support (Passkeys):
- iOS: Version 15+ required for platform-level support
Expand Down
4 changes: 4 additions & 0 deletions example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ android {
buildFeatures {
buildConfig = true
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
buildTypes {
debug {
signingConfig signingConfigs.debug
Expand Down
2 changes: 1 addition & 1 deletion example/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# are providing them.
newArchEnabled=false

# Allow JVM target mismatch between Kotlin (17) and Java (11) in dependencies
# Warn (do not fail) if a transitive dependency still uses a different JVM target
kotlin.jvm.target.validation.mode=warning

# Use this property to enable or disable the Hermes JS engine.
Expand Down
Loading