Repository navigation
chore: prepare release v0.3.6 - #128
Conversation
Bump Bushel and replace yanked chacha20 0.10.1 with 0.10.2 without other dependency changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package version changes from 0.3.5 to 0.3.6. Health-banner hints now use the chrome formatter. Interaction tests cover the banners across panes, layouts, sizes, and error text. ChangesHealth Banner Formatting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The reviewed changes are mergeable after normal checks; no concrete current-head risk remains identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the banner glow, Comment |
Preserve published release ancestry and the two-file version/chacha20 diff.
Preserve external Unicode errors while converting application-owned stats and resource-read banner suffixes. Cover stats, images, volumes and networks in both layouts at floor and wide sizes.
Prepare Bushel 0.3.6 with the merged audit fixes. Cargo.toml and Cargo.lock change the application version and replace yanked chacha20 0.10.1 with 0.10.2; structural comparison against current main verifies every other package version and dependency edge is preserved. A separate integration correction fixes ASCII health-banner punctuation with regression tests.
Integrated main: 0f24599 (PR119, PR125, PR126 and PR127).
Final head: ba7e1ae.
Final tree: ca20bb65a0140ff656724ee03c8cbe4d1abb4bd6.
Integration commit 9088e0d preserves published release ancestry with parents 3ef3a04 and 0f24599.
Proposed release notes
bushel updatetells cargo users to install git HEAD, not crates.io #97, Invalid or richer config is overwritten by a settings toggle; write one key #98, Stream Exit can overtake final output lines; send Exit after readers drain #104).All four audit PRs are merged and included. Compatibility claims and TESTED_* ranges remain unchanged. Native stopped-container backlog retrieval and macOS 27 support are not claimed.
Regression and validation
The independent coordinator review found stats banners' middle dot and resource-read banners' em dash/middle dot bypassed Theme. Four new render tests failed against the integrated source before the fix (stats, images, volumes, networks). The fix converts only application-owned suffixes through Theme::chrome, leaving external gists untouched. All 24 UI interaction tests then pass, including the external Unicode preservation test. Cases cover Rail/Table at 55x20 and 120x40.
Full exact-head checks passed from a clean checkout with an isolated build target:
Remote CI passed on the exact final head: https://github.com/frankieramirez/bushel/actions/runs/37610809782 — macOS fmt/clippy/test and Linux docs/assets/publish dry-run jobs all completed successfully. Release planning passed: https://github.com/frankieramirez/bushel/actions/runs/37610810205. CodeRabbit status is success.
Evidence: /tmp/bushel-release-final-ba7e1ae and /tmp/bushel-release-final-9088e0d/health-banners-{red,green}.txt.
Release controls and limits
Draft only. Coordinator reviews the final version PR and explicitly directs tagging/publication. No tag, release, actual cargo upload or deploy hook invocation was performed.
PR events plan only; tag pushes publish. Existing HOMEBREW_TAP_TOKEN is required to update the tap before announcement. BUSHEL_SH_DEPLOY_HOOK absence fails site deployment. CARGO_REGISTRY_TOKEN absence silently skips crates.io upload; same-version manual publication is then required. No credentials or repository settings are created or changed here.
Linux cloud verification cannot exercise Apple Containers virtualization or real interactive terminal restoration. Physical/self-hosted Apple silicon validation is mandatory before expanding the tested CLI range or claiming macOS 27 support. Existing cloud GitHub CLI GH_TOKEN is invalid; connector writes and git work.
Summary by CodeRabbit
Bug Fixes
Tests