Skip to content

Lines exceeding 80 characters#352

Open
fatmage wants to merge 2 commits into
fram-lang:masterfrom
fatmage:overly-long-lines
Open

Lines exceeding 80 characters#352
fatmage wants to merge 2 commits into
fram-lang:masterfrom
fatmage:overly-long-lines

Conversation

@fatmage

@fatmage fatmage commented May 29, 2026

Copy link
Copy Markdown
Member

Reformatted lines which were exceeding 80 characters of length.

List of remaining files which break the 80 character rule:

src/Lsp/State.mli, line: 17, length: 120
test/err/tc_0022_or_pattern_mismatch.fram, line: 7, length: 110
test/err/tc_0023_or_pattern_var_mismatch_2.fram, line: 7, length: 110
test/err/tc_0023_or_pattern_var_mismatch_2.fram, line: 8, length: 110
test/err/tc_0024_or_pattern_scheme_mismatch.fram, line: 6, length: 150
test/err/tc_0025_or_pattern_module_mismatch.fram, line: 7, length: 99

Message.ml and State.mli contain a link which is in itself longer than 80 characters, and the test files contain an error message which needs to be validated which is longer than 80 characters.

Comment thread lib/Testing.fram
assertTrue
{msg =
"Assertion Failed: Expected \{expected.show} and \{actual.show} to be equal"}
"Assertion Failed: Expected \{expected.show}" +

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this line uses string interpolation it can be broken down without string concatenation as such:

"Assertion Failed: Expected \{
    expected.show
} and \{
    actual.show
} to be equal"}

or

"Assertion Failed: Expected \{expected.show
} and \{actual.show} to be equal"}

I dont know if and which version is better honestly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants