Skip to content

Allow updating an existing session key - #160

Merged
mguida22 merged 2 commits into
mainfrom
cursor/update-session-key-b8f3
Aug 28, 2026
Merged

Allow updating an existing session key#160
mguida22 merged 2 commits into
mainfrom
cursor/update-session-key-b8f3

Conversation

@mguida22

@mguida22 mguida22 commented Aug 27, 2026

Copy link
Copy Markdown
Member

Changelog

Add a new_key parameter to Client.update_session so callers can rename a session after creation.

Docs

None

Description

Allows updating an existing session with a new key.

Add a key parameter to Client.update_session so callers can rename a
session. The current session_key stays the lookup identifier for
PATCH /v1/sessions/{keyOrId}.

Co-authored-by: Mike Guida <mike@mguida.com>
@mguida22
mguida22 marked this pull request as ready for review August 27, 2026 20:03
@linear-code

linear-code Bot commented Aug 27, 2026

Copy link
Copy Markdown

DC-1621

Comment thread foxglove/client/api.py Outdated
Match update_device(new_name=...) so the lookup identifier
(session_key) is distinct from the value to assign.

Co-authored-by: Mike Guida <mike@mguida.com>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguida22
mguida22 requested a review from brookfxg August 27, 2026 20:13
@mguida22
mguida22 merged commit 2279965 into main Aug 28, 2026
2 checks passed
@mguida22
mguida22 deleted the cursor/update-session-key-b8f3 branch August 28, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants