Skip to content

fix(security): escape survey WebView payload to prevent </script> injection (ENG-1813) #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattinannt merged 3 commits into from
Jul 21, 2026
Merged

fix(security): escape survey WebView payload to prevent </script> injection (ENG-1813) #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bec0f1
fixes the js payload backtick bug
pandeymangg Jul 21, 2026
4a3e187
refactor: satisfy sonar for payload escaping (ENG-1813)
pandeymangg Jul 21, 2026
bc4056e
run checks
pandeymangg Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/react-native/src/components/survey-web-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,15 @@ const renderHtml = (
`;
}

// Escape "<" so survey content can't inject "</script>" (or "<script"/"<!--") and break
// out of the inline <script> below: "<" occurs only inside JSON string values, and the
// WebView's JS engine decodes the escaped "<" back to a literal "<" when parsing the
// object literal, so the payload is preserved exactly. See ENG-1813.
const optionsJson = JSON.stringify(options).replaceAll(
"<",
String.raw`\u003c`,
);

return `
<!doctype html>
<html>
Expand Down Expand Up @@ -372,7 +381,7 @@ const renderHtml = (
function getSetIsError() { /* noop */ };

function loadSurvey() {
const options = ${JSON.stringify(options)};
const options = ${optionsJson};
const surveyProps = {
...options,
onDisplayCreated,
Expand Down
Loading