Fix the discover integration test against the merged promo hook - #152
Conversation
PR 150 wrote the test against the hook where promoCodeVerified was a prop; PR 151 made acceptance the hook's own state, earned by validating. Merged together, the prop is ignored and the discovered code never counts as active. The test now runs one successful validation, the way the app reaches that state.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe integration test now matches the current promo-code hook validation flow. It uses ChangesPromo code test alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This is a localized test-only update that aligns the integration test with the merged promotion-hook behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ref: https://app.clickup.com/t/86bb9xgex
Fixes the CI break on main after #150 and #151 merged.
Each PR was green alone. #150's integration test fed the promo hook promoCodeVerified as a prop; #151 moved that state inside the hook, where it is earned by validating. Merged together, the prop is ignored, the discovered code never counts as active, and the test fails.
The test now runs one successful validation against a qualifying ticket, the way the app reaches that state. Test-only change; 133 unit and 33 e2e green on merged main plus this fix.
Summary by CodeRabbit