fix: relax dataclasses-json upper bound from <0.5.12 to <0.6.0 - #3463
Open
honnix wants to merge 1 commit into
Open
fix: relax dataclasses-json upper bound from <0.5.12 to <0.6.0#3463honnix wants to merge 1 commit into
honnix wants to merge 1 commit into
Conversation
honnix
force-pushed
the
honnix/relax-dataclasses-json-upper-bound
branch
from
August 27, 2026 12:29
3c0cae8 to
626d27e
Compare
The <0.5.12 cap was added when 0.5.12 dropped the marshmallow-enum transitive dependency. Since flytekit now declares marshmallow-enum as a direct dependency, 0.5.12–0.5.14 are safe. The <0.6.0 cap remains because 0.6.0 removes marshmallow-enum support entirely in favor of native Enum, which breaks type_engine.py. Ref: flyteorg/flyte#3873 Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
force-pushed
the
honnix/relax-dataclasses-json-upper-bound
branch
from
August 27, 2026 12:31
626d27e to
d374667
Compare
honnix
marked this pull request as ready for review
August 27, 2026 12:44
honnix
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
August 27, 2026 12:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3463 +/- ##
==========================================
+ Coverage 82.94% 83.58% +0.64%
==========================================
Files 264 3 -261
Lines 26755 195 -26560
Branches 3036 0 -3036
==========================================
- Hits 22192 163 -22029
+ Misses 3702 32 -3670
+ Partials 861 0 -861 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataclasses-jsonupper bound from<0.5.12to<0.6.0<0.5.12cap was added when 0.5.12 droppedmarshmallow-enumas a transitive dependency (flyte#3873). Since flytekit now declaresmarshmallow-enumas a direct dependency, 0.5.12–0.5.14 are safe<0.6.0cap remains because 0.6.0 removesmarshmallow-enumsupport entirely in favor of native Enum, which breakstype_engine.pyTest plan
marshmallow_enum.EnumFieldimport intype_engine.pystill works🤖 Generated with Claude Code