Skip to content

fix: relax dataclasses-json upper bound from <0.5.12 to <0.6.0 - #3463

Open
honnix wants to merge 1 commit into
masterfrom
honnix/relax-dataclasses-json-upper-bound
Open

fix: relax dataclasses-json upper bound from <0.5.12 to <0.6.0#3463
honnix wants to merge 1 commit into
masterfrom
honnix/relax-dataclasses-json-upper-bound

Conversation

@honnix

@honnix honnix commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Relaxes the dataclasses-json upper bound from <0.5.12 to <0.6.0
  • The <0.5.12 cap was added when 0.5.12 dropped marshmallow-enum as a transitive dependency (flyte#3873). Since flytekit now declares marshmallow-enum as a direct dependency, 0.5.12–0.5.14 are safe
  • The <0.6.0 cap remains because 0.6.0 removes marshmallow-enum support entirely in favor of native Enum, which breaks type_engine.py

Test plan

  • Verify flytekit imports succeed with dataclasses-json 0.5.14
  • Verify marshmallow_enum.EnumField import in type_engine.py still works

🤖 Generated with Claude Code

@honnix
honnix force-pushed the honnix/relax-dataclasses-json-upper-bound branch from 3c0cae8 to 626d27e Compare August 27, 2026 12:29
The <0.5.12 cap was added when 0.5.12 dropped the marshmallow-enum
transitive dependency. Since flytekit now declares marshmallow-enum
as a direct dependency, 0.5.12–0.5.14 are safe. The <0.6.0 cap
remains because 0.6.0 removes marshmallow-enum support entirely
in favor of native Enum, which breaks type_engine.py.

Ref: flyteorg/flyte#3873
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
@honnix
honnix force-pushed the honnix/relax-dataclasses-json-upper-bound branch from 626d27e to d374667 Compare August 27, 2026 12:31
@honnix
honnix marked this pull request as ready for review August 27, 2026 12:44
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.58%. Comparing base (d69b3fb) to head (d374667).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
+ Coverage   82.94%   83.58%   +0.64%     
==========================================
  Files         264        3     -261     
  Lines       26755      195   -26560     
  Branches     3036        0    -3036     
==========================================
- Hits        22192      163   -22029     
+ Misses       3702       32    -3670     
+ Partials      861        0     -861     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant