Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Copy the final head primary container’s securityContext into KubeRay autoscaler options when autoscaling is enabled. Configured logs sidecars inherit that context only when their context is unset.
Preserve explicit logs contexts, head-template overrides, and existing behavior when autoscaling is disabled.
Customer-Facing Change Log
Ray autoscaler and logs sidecars inherit the head container’s security settings.
Test Plan (required)
Added regression coverage for inheritance, overrides, nil and empty contexts, disabled autoscaling, primary selection, and deep-copy isolation.
Passed: go test -mod=readonly -race -p 2 ./flyteplugins/...
CI pending PR creation. Combined E2E validation follows the remaining Apple fixes.
Rollout Plan (required)
Consume this change together with ENG26-1566 in one Cloud flyte2 pin update after both upstream fixes merge. Run E2E after ENG26-1564/1565/1566 merge.
Rollback Plan (required)
Revert the inheritance change upstream and consume the revert through a Cloud pin update.
Issue
Ref https://linear.app/unionai/issue/ENG26-1565