Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Apply the configured primary-container security context before copilot setup, then inherit the primary's effective context into generated downloader/uploader containers after accelerator and base PodTemplate merging. Explicit helper contexts, including partial and empty ones, are preserved; each inherited context is independently copied. See pod configuration ordering and copilot inheritance.
This change is scoped to Flyte 2 and keeps exported signatures and configuration keys unchanged.
Customer-Facing Change Log
Flyte 2 copilot tasks apply configured container security defaults to the primary container and inherit its effective context into downloader/uploader helpers that lack their own context.
Test Plan (required)
go test -mod=readonly -race ./flyteplugins/go/tasks/pluginmachinery/flytek8s ./flyteplugins/go/tasks/plugins/k8s/pod -count=1.flytek8spackage again with-mod=readonly -race -count=1.git diff --check. Remote CI pending.Rollout Plan (required)
Target the current development branch, with no backport. Cloud submodule updates, runtime image builds, chart publication, and combined E2E validation belong to the shared Apple delivery follow-up.
Rollback Plan (required)
Revert this source change before shared release integration if required. Deployment rollback verification is deferred with that release work.
Issue
Ref https://linear.app/unionai/issue/ENG26-1566