Repository navigation
feat(idl): add WORKER_KIND_GVISOR - #8424
Merged
Merged
Conversation
A worker kind for tasks that each run in their own gVisor sandbox, such as interactive sandbox sessions, so a scheduler can route them separately from microVM sessions. Like WORKER_KIND_MICROVM, such tasks should not be retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
EngHabu
previously approved these changes
Nov 18, 2026
Matches check-generate's make buf output (buf 1.58.0): the Rust bindings' file descriptor set and the connector swagger that embeds WorkerKind's docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
kumare3
enabled auto-merge (squash)
November 18, 2026 02:08
EngHabu
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
WORKER_KIND_GVISOR = 4toflyteidl2.core.WorkerKind, for tasks that each run in their own gVisor sandbox (a user-space kernel), such as interactive sandbox sessions.Today gVisor and microVM sessions both use
WORKER_KIND_MICROVMand are told apart only bytask_type_version. With a separate kind, a scheduler can send each to a worker of its own kind. As withWORKER_KIND_MICROVM, schedulers that support this kind should not retry such a task: a retry would start a fresh sandbox at a new address while callers still hold the old one. The open-source executor does not treat it specially.Changes
flyteidl2/core/tasks.proto: the new enum value and its doc comment.tasks.proto.gen/rust/src/flyteidl2.core.rs: the new variant, added by hand. A local regen of the Rust bindings reorders the whole file, so this keeps the diff to the enum.Test plan
buf generatefor go, python and ts ontasks.proto: the only output changes are the new value.WORKER_KIND_GVISORsessions only to gVisor workers, with unit tests for routing and retry semantics.🤖 Generated with Claude Code