Skip to content

feat(idl): add WORKER_KIND_GVISOR - #8424

Merged
kumare3 merged 2 commits into
mainfrom
ketan/worker-kind-gvisor
Nov 18, 2026
Merged

kumare3 merged 2 commits into
mainfrom
ketan/worker-kind-gvisor

Conversation

@kumare3

@kumare3 kumare3 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds WORKER_KIND_GVISOR = 4 to flyteidl2.core.WorkerKind, for tasks that each run in their own gVisor sandbox (a user-space kernel), such as interactive sandbox sessions.

Today gVisor and microVM sessions both use WORKER_KIND_MICROVM and are told apart only by task_type_version. With a separate kind, a scheduler can send each to a worker of its own kind. As with WORKER_KIND_MICROVM, schedulers that support this kind should not retry such a task: a retry would start a fresh sandbox at a new address while callers still hold the old one. The open-source executor does not treat it specially.

Changes

  • flyteidl2/core/tasks.proto: the new enum value and its doc comment.
  • Regenerated Go, Python and TS bindings for tasks.proto.
  • gen/rust/src/flyteidl2.core.rs: the new variant, added by hand. A local regen of the Rust bindings reorders the whole file, so this keeps the diff to the enum.

Test plan

  • buf generate for go, python and ts on tasks.proto: the only output changes are the new value.
  • Consumed downstream: the scheduler routes WORKER_KIND_GVISOR sessions only to gVisor workers, with unit tests for routing and retry semantics.

🤖 Generated with Claude Code

A worker kind for tasks that each run in their own gVisor sandbox, such as
interactive sandbox sessions, so a scheduler can route them separately from
microVM sessions. Like WORKER_KIND_MICROVM, such tasks should not be retried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 01:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

EngHabu
EngHabu previously approved these changes Nov 18, 2026
Matches check-generate's make buf output (buf 1.58.0): the Rust bindings'
file descriptor set and the connector swagger that embeds WorkerKind's docs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 02:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@kumare3
kumare3 enabled auto-merge (squash) November 18, 2026 02:08
@kumare3
kumare3 merged commit e57992d into main Nov 18, 2026
24 checks passed
@kumare3
kumare3 deleted the ketan/worker-kind-gvisor branch November 18, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants