Skip to content

Add queue to the image lookup request - #8394

Closed
EngHabu wants to merge 1 commit into
mainfrom
haytham/image-request-queue
Closed

EngHabu wants to merge 1 commit into
mainfrom
haytham/image-request-queue

Conversation

@EngHabu

@EngHabu EngHabu commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

A client checking whether an image already exists before building it (ImageService.GetImage) cannot say which queue the image is for. A control plane then looks it up in the project-domain's default cluster. For a queue that runs on another cluster (in Union, a shared queue served by another organization's cluster), the image was built into that cluster's registry, so the lookup misses and the client builds again on every run.

What changes were proposed in this pull request?

GetImageRequest gains an optional string queue = 4, matching CreateUploadLocationRequest.queue (#8216). Regenerated Go, Python, Rust and TypeScript bindings for flyteidl2/imagebuilder/payload.proto only.

How was this patch tested?

buf generate for the four targets; the change is additive (an optional field), so existing clients and servers are unaffected. The SDK and Union control plane changes that set and read it follow in their own PRs.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

GetImageRequest gains an optional queue, like CreateUploadLocationRequest's (#8216): a client
checking whether an image it would build for a queue already exists names that queue, so a
control plane can look the image up in the registry of the cluster that queue runs on (for a
shared queue, another organization's cluster) instead of the project-domain's default cluster.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EuLd1BzGe4q6GrXKAQf2tg
Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
@EngHabu
EngHabu enabled auto-merge (squash) November 12, 2026 17:23
@EngHabu

EngHabu commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Not needed: flyte-sdk#1771 (in 2.13.1+) already routes image lookups by the run's queue through SelectCluster, which finds the image in the shared queue's cluster registry.

@EngHabu EngHabu closed this Nov 12, 2026
auto-merge was automatically disabled November 12, 2026 17:24

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants