Repository navigation
Conversation
GetImageRequest gains an optional queue, like CreateUploadLocationRequest's (#8216): a client checking whether an image it would build for a queue already exists names that queue, so a control plane can look the image up in the registry of the cluster that queue runs on (for a shared queue, another organization's cluster) instead of the project-domain's default cluster. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuLd1BzGe4q6GrXKAQf2tg Signed-off-by: Haytham Abuelfutuh <haytham@union.ai>
EngHabu
enabled auto-merge (squash)
November 12, 2026 17:23
pingsutw
approved these changes
Nov 12, 2026
Contributor
Author
|
Not needed: flyte-sdk#1771 (in 2.13.1+) already routes image lookups by the run's queue through SelectCluster, which finds the image in the shared queue's cluster registry. |
auto-merge was automatically disabled
November 12, 2026 17:24
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
A client checking whether an image already exists before building it (
ImageService.GetImage) cannot say which queue the image is for. A control plane then looks it up in the project-domain's default cluster. For a queue that runs on another cluster (in Union, a shared queue served by another organization's cluster), the image was built into that cluster's registry, so the lookup misses and the client builds again on every run.What changes were proposed in this pull request?
GetImageRequestgains an optionalstring queue = 4, matchingCreateUploadLocationRequest.queue(#8216). Regenerated Go, Python, Rust and TypeScript bindings forflyteidl2/imagebuilder/payload.protoonly.How was this patch tested?
buf generatefor the four targets; the change is additive (an optional field), so existing clients and servers are unaffected. The SDK and Union control plane changes that set and read it follow in their own PRs.Check all the applicable boxes